[SCSI] hpsa: avoid leaking stack contents to userland (938abd84) · Commits · 戴 / test

memset arg64 to zero in the passthrough ioctls to avoid leaking contents of kernel stack memory to userland via uninitialized padding fields inserted by the compiler for alignment reasons. Signed-off-by:

Stephen M. Cameron <scameron@beardog.cce.hp.com> Signed-off-by:

James Bottomley <James.Bottomley@suse.de>

drivers/scsi/hpsa.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -2310,6 +2310,7 @@ static int hpsa_ioctl32_passthru(struct scsi_device dev, int cmd, void arg)
		int err;
		u32 cp;

		memset(&arg64, 0, sizeof(arg64));
		err = 0;
		err \|= copy_from_user(&arg64.LUN_info, &arg32->LUN_info,
		sizeof(arg64.LUN_info));
		@@ -2346,6 +2347,7 @@ static int hpsa_ioctl32_big_passthru(struct scsi_device *dev,
		int err;
		u32 cp;

		memset(&arg64, 0, sizeof(arg64));
		err = 0;
		err \|= copy_from_user(&arg64.LUN_info, &arg32->LUN_info,
		sizeof(arg64.LUN_info));

Admin message