Commit 9377abd0 authored May 12, 2008 by Jan Kara Committed by Linus Torvalds May 13, 2008

quota: don't call sync_fs() from vfs_quota_off() when there's no quota turn off



Sometimes, vfs_quota_off() is called on a partially set up super block (for
example when fill_super() fails for some reason).  In such cases we cannot
call ->sync_fs() because it can Oops because of not properly filled in super
block.  So in case we find there's not quota to turn off, we just skip
everything and return which fixes the above problem.

[akpm@linux-foundation.org: fxi tpyo]
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent bb45d642

fs/dquot.c

+10 −0

Original line number	Diff line number	Diff line
		@@ -1491,6 +1491,16 @@ int vfs_quota_off(struct super_block *sb, int type, int remount)

		/* We need to serialize quota_off() for device */
		mutex_lock(&dqopt->dqonoff_mutex);

		/*
		* Skip everything if there's nothing to do. We have to do this because
		* sometimes we are called when fill_super() failed and calling
		* sync_fs() in such cases does no good.
		*/
		if (!sb_any_quota_enabled(sb) && !sb_any_quota_suspended(sb)) {
		mutex_unlock(&dqopt->dqonoff_mutex);
		return 0;
		}
		for (cnt = 0; cnt < MAXQUOTAS; cnt++) {
		toputinode[cnt] = NULL;
		if (type != -1 && cnt != type)

Admin message