Commit 936d5bf1 authored by Michael Ellerman's avatar Michael Ellerman Committed by Paul Mackerras
Browse files

[POWERPC] spufs: Get rid of spufs_coredump_num_notes, it's not needed if we NULL terminate 



The spufs_coredump_read array is NULL terminated, and we also store the size.
We only need one or the other, and the other arrays in file.c are NULL
terminated, so do that.

Signed-off-by: default avatarMichael Ellerman <michael@ellerman.id.au>
Signed-off-by: default avatarJeremy Kerr <jk@ozlabs.org>
Signed-off-by: default avatarPaul Mackerras <paulus@samba.org>
parent c1a72173

arch/powerpc/platforms/cell/spufs/coredump.c

+2 −2
Original line number Diff line number Diff line
@@ -72,7 +72,7 @@ static int spufs_ctx_note_size(struct spu_context *ctx, int dfd) 
	char *name;

	char fullname[80];



	for (i = 0; spufs_coredump_read[i].name; i++) {

	for (i = 0; spufs_coredump_read[i].name != NULL; i++) {

		name = spufs_coredump_read[i].name;

		sz = spufs_coredump_read[i].size;
@@ -194,7 +194,7 @@ static void spufs_arch_write_notes(struct file *file) 
	while ((ctx = coredump_next_context(&fd)) != NULL) {

		spu_acquire_saved(ctx);



		for (j = 0; j < spufs_coredump_num_notes; j++)

		for (j = 0; spufs_coredump_read[j].name != NULL; j++)

			spufs_arch_write_note(ctx, j, file, fd);



		spu_release_saved(ctx);

arch/powerpc/platforms/cell/spufs/file.c

+1 −3
Original line number Diff line number Diff line
@@ -2250,7 +2250,5 @@ struct spufs_coredump_reader spufs_coredump_read[] = { 
	{ "proxydma_info", __spufs_proxydma_info_read,

			   NULL, sizeof(struct spu_proxydma_info)},

	{ "object-id", NULL, __spufs_object_id_get, 19 },

	{ },

	{ NULL },

};
 
int spufs_coredump_num_notes = ARRAY_SIZE(spufs_coredump_read) - 1;

CRA Git | Maintained and supported by SUSTech CRA and CCSE