Commit 934f585e authored Apr 30, 2013 by Julien Grall Committed by Konrad Rzeszutek Wilk May 08, 2013

xen: clear IRQ_NOAUTOEN and IRQ_NOREQUEST

Reset the IRQ_NOAUTOEN and IRQ_NOREQUEST flags that are enabled by
default on ARM. If IRQ_NOAUTOEN is set, __setup_irq doesn't call
irq_startup, that is responsible for calling irq_unmask at startup time.
As a result event channels remain masked.

The clear is already made in bind_evtchn_to_irq with commit a8636c0b but was
missing on all others bind_*_to_irq. Move the clear in xen_irq_info_common_init.

On x86, IRQ_NOAUTOEN and IRQ_NOREQUEST are cleared by default, so this commit
doesn't impact this architecture.

Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: Julien Grall <julien.grall@linaro.org>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

parent 4ea9b9ac

drivers/xen/events.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -167,6 +167,8 @@ static void xen_irq_info_common_init(struct irq_info *info,
		info->cpu = cpu;

		evtchn_to_irq[evtchn] = irq;

		irq_clear_status_flags(irq, IRQ_NOREQUEST\|IRQ_NOAUTOEN);
		}

		static void xen_irq_info_evtchn_init(unsigned irq,
		@@ -874,7 +876,6 @@ int bind_evtchn_to_irq(unsigned int evtchn)
		struct irq_info *info = info_for_irq(irq);
		WARN_ON(info == NULL \|\| info->type != IRQT_EVTCHN);
		}
		irq_clear_status_flags(irq, IRQ_NOREQUEST\|IRQ_NOAUTOEN);

		out:
		mutex_unlock(&irq_mapping_update_lock);

Admin message