Commit 9334ae5e authored Nov 15, 2018 by Jens Axboe

ide: clear ide_req()->special for non-passthrough requests



The initial patch cleared this for all requests, which is wrong
since internal uses can't have this cleared as that's what they
are using to pass data. The fix moved the initialization to the
mq_ops->initialize_rq_fn(), but that's only a partial fix since
it only catches uses from blk_get_request(), not requests coming
from the file system.

Keep the non-fs initialization, and add the IDE entry clear
IFF RQF_DONTPREP isn't set and it's a passthrough request.

Fixes: d16a6766 ("ide: don't clear special on ide_queue_rq() entry")
Fixes: 22ce0a7c ("ide: don't use req->special")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent db29eb05

drivers/ide/ide-io.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -463,6 +463,11 @@ blk_status_t ide_queue_rq(struct blk_mq_hw_ctx *hctx,
		struct request *rq = bd->rq;
		ide_startstop_t startstop;

		if (!blk_rq_is_passthrough(rq) && !(rq->rq_flags & RQF_DONTPREP)) {
		rq->rq_flags \|= RQF_DONTPREP;
		ide_req(rq)->special = NULL;
		}

		/* HLD do_request() callback might sleep, make sure it's okay */
		might_sleep();

Admin message