RDMA/core: Fix error code in stat_get_doit_qp() (932727c5) · Commits · 戴 / test

We need to set the error codes on these paths. Currently the only possible error code is -EMSGSIZE so that's what the patch uses. Fixes: ("RDMA/nldev: Allow get counter mode through RDMA netlink") Signed-off-by:

Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:

Leon Romanovsky <leonro@mellanox.com> Link: https://lore.kernel.org/r/20190809101311.GA17867@mwanda Signed-off-by:

Doug Ledford <dledford@redhat.com>

drivers/infiniband/core/nldev.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -1952,12 +1952,16 @@ static int stat_get_doit_qp(struct sk_buff skb, struct nlmsghdr nlh,

		if (fill_nldev_handle(msg, device) \|\|
		nla_put_u32(msg, RDMA_NLDEV_ATTR_PORT_INDEX, port) \|\|
		nla_put_u32(msg, RDMA_NLDEV_ATTR_STAT_MODE, mode))
		nla_put_u32(msg, RDMA_NLDEV_ATTR_STAT_MODE, mode)) {
		ret = -EMSGSIZE;
		goto err_msg;
		}

		if ((mode == RDMA_COUNTER_MODE_AUTO) &&
		nla_put_u32(msg, RDMA_NLDEV_ATTR_STAT_AUTO_MODE_MASK, mask))
		nla_put_u32(msg, RDMA_NLDEV_ATTR_STAT_AUTO_MODE_MASK, mask)) {
		ret = -EMSGSIZE;
		goto err_msg;
		}

		nlmsg_end(msg, nlh);
		ib_device_put(device);

Admin message