Commit 9324df58 authored Feb 21, 2019 by Chris Lew Committed by Andy Gross Mar 27, 2019

soc: qcom: qmi: Change txn wait to non-interruptible



Current QMI clients are not userspace facing, if their threads are
signaled, they do not do any signal checking or propagate the
ERESTARTSYS return code up. Remove the interruptible option so clients
can finish their QMI transactions even if the thread is signaled.

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Chris Lew <clew@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Andy Gross <andy.gross@linaro.org>

parent 8da3daaa

drivers/soc/qcom/qmi_interface.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -345,8 +345,7 @@ int qmi_txn_wait(struct qmi_txn *txn, unsigned long timeout)
		struct qmi_handle *qmi = txn->qmi;
		int ret;

		ret = wait_for_completion_interruptible_timeout(&txn->completion,
		timeout);
		ret = wait_for_completion_timeout(&txn->completion, timeout);

		mutex_lock(&qmi->txn_lock);
		mutex_lock(&txn->lock);
		@@ -354,9 +353,7 @@ int qmi_txn_wait(struct qmi_txn *txn, unsigned long timeout)
		mutex_unlock(&txn->lock);
		mutex_unlock(&qmi->txn_lock);

		if (ret < 0)
		return ret;
		else if (ret == 0)
		if (ret == 0)
		return -ETIMEDOUT;
		else
		return txn->result;

Admin message