Commit 9307f6b1 authored Feb 16, 2010 by Alasdair G Kergon

dm: sysfs revert add empty release function to avoid debug warning



Revert commit d2bb7df8 at Greg's request.

    Author: Milan Broz <mbroz@redhat.com>
    Date:   Thu Dec 10 23:51:53 2009 +0000

    dm: sysfs add empty release function to avoid debug warning

    This patch just removes an unnecessary warning:
     kobject: 'dm': does not have a release() function,
     it is broken and must be fixed.

    The kobject is embedded in mapped device struct, so
    code does not need to release memory explicitly here.

Cc: Greg KH <gregkh@suse.de>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>

parent 9eef87da

drivers/md/dm-sysfs.c

+0 −8

Original line number	Diff line number	Diff line
		@@ -79,13 +79,6 @@ static struct sysfs_ops dm_sysfs_ops = {
		.show = dm_attr_show,
		};

		/*
		* The sysfs structure is embedded in md struct, nothing to do here
		*/
		static void dm_sysfs_release(struct kobject *kobj)
		{
		}

		/*
		* dm kobject is embedded in mapped_device structure
		* no need to define release function here
		@@ -93,7 +86,6 @@ static void dm_sysfs_release(struct kobject *kobj)
		static struct kobj_type dm_ktype = {
		.sysfs_ops = &dm_sysfs_ops,
		.default_attrs = dm_attrs,
		.release = dm_sysfs_release
		};

		/*

Admin message