octeontx2-vf: Fix error return code in otx2vf_probe() (9302bead) · Commits · 戴 / test

Fix to return negative error code -ENOMEM from the alloc failed error handling case instead of 0, as done elsewhere in this function. Fixes: ("octeontx2-vf: Virtual function driver support") Reported-by:

Hulk Robot <hulkci@huawei.com> Signed-off-by:

Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by:

Jakub Kicinski <kuba@kernel.org>

drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -497,13 +497,17 @@ static int otx2vf_probe(struct pci_dev pdev, const struct pci_device_id id)

		hw->irq_name = devm_kmalloc_array(&hw->pdev->dev, num_vec, NAME_SIZE,
		GFP_KERNEL);
		if (!hw->irq_name)
		if (!hw->irq_name) {
		err = -ENOMEM;
		goto err_free_netdev;
		}

		hw->affinity_mask = devm_kcalloc(&hw->pdev->dev, num_vec,
		sizeof(cpumask_var_t), GFP_KERNEL);
		if (!hw->affinity_mask)
		if (!hw->affinity_mask) {
		err = -ENOMEM;
		goto err_free_netdev;
		}

		err = pci_alloc_irq_vectors(hw->pdev, num_vec, num_vec, PCI_IRQ_MSIX);
		if (err < 0) {

Admin message