Commit 92fa1242 authored May 01, 2015 by Lars-Peter Clausen Committed by Mark Brown May 06, 2015

ASoC: dapm: Add new widgets to the end of the widget list



Currently new widgets are appended to the beginning of the cards widget
list. This has the effect that widgets that are created while iterating
over the widget list in snd_soc_dapm_new_widgets() (like e.g. the
auto-disable widgets) are not covered during that invocation of the
function. If no further invocations of snd_soc_dapm_new_widgets() happen
these widgets will not be fully initialized and e.g. no debugfs entries are
created for them.

By adding new widgets to the end of the widget list we make sure that
widgets that are created in snd_soc_dapm_new_widgets() will still be
handled during the same snd_soc_dapm_new_widgets() invocation and are
always fully initialized.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 561ed680

sound/soc/soc-dapm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3252,7 +3252,7 @@ snd_soc_dapm_new_control(struct snd_soc_dapm_context *dapm,
		INIT_LIST_HEAD(&w->sinks);
		INIT_LIST_HEAD(&w->list);
		INIT_LIST_HEAD(&w->dirty);
		list_add(&w->list, &dapm->card->widgets);
		list_add_tail(&w->list, &dapm->card->widgets);

		w->inputs = -1;
		w->outputs = -1;

Admin message