Commit 92d72f1b authored Oct 25, 2019 by Colin Ian King Committed by David S. Miller Oct 29, 2019

net: aquantia: fix unintention integer overflow on left shift



Shifting the integer value 1 is evaluated using 32-bit
arithmetic and then used in an expression that expects a 64-bit
value, so there is potentially an integer overflow. Fix this
by using the BIT_ULL macro to perform the shift and avoid the
overflow.

Addresses-Coverity: ("Unintentional integer overflow")
Fixes: 04a18399 ("net: aquantia: implement data PTP datapath")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Igor Russkikh <irusskikh@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 69977901

drivers/net/ethernet/aquantia/atlantic/aq_ptp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -713,7 +713,7 @@ static int aq_ptp_poll(struct napi_struct *napi, int budget)
		if (work_done < budget) {
		napi_complete_done(napi, work_done);
		aq_nic->aq_hw_ops->hw_irq_enable(aq_nic->aq_hw,
		1 << aq_ptp->ptp_ring_param.vec_idx);
		BIT_ULL(aq_ptp->ptp_ring_param.vec_idx));
		}

		err_exit:

Admin message