driver core: fix build with SYSFS=n (92b42141) · Commits · 戴 / test

When SYSFS=n and MODULES=y, build ends with: linux-2.6.24-rc6-mm1/drivers/base/module.c: In function 'module_add_driver': linux-2.6.24-rc6-mm1/drivers/base/module.c:49: error: 'module_kset' undeclared (first use in this function) make[3]: *** [drivers/base/module.o] Error 1 Below is one possible fix. Build-tested with all 4 config combinations of SYSFS & MODULES. Signed-off-by:

Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by:

Greg Kroah-Hartman <gregkh@suse.de>

drivers/base/Makefile

+2 −0

Original line number	Diff line number	Diff line
		@@ -11,7 +11,9 @@ obj-$(CONFIG_FW_LOADER) += firmware_class.o
		obj-$(CONFIG_NUMA) += node.o
		obj-$(CONFIG_MEMORY_HOTPLUG_SPARSE) += memory.o
		obj-$(CONFIG_SMP) += topology.o
		ifeq ($(CONFIG_SYSFS),y)
		obj-$(CONFIG_MODULES) += module.o
		endif
		obj-$(CONFIG_SYS_HYPERVISOR) += hypervisor.o

		ifeq ($(CONFIG_DEBUG_DRIVER),y)

drivers/base/base.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -81,7 +81,7 @@ extern int devres_release_all(struct device *dev);

		extern struct kset *devices_kset;

		#ifdef CONFIG_MODULES
		#if defined(CONFIG_MODULES) && defined(CONFIG_SYSFS)
		extern void module_add_driver(struct module mod, struct device_driver drv);
		extern void module_remove_driver(struct device_driver *drv);
		#else

Admin message