Commit 92b32772 authored Jan 06, 2019 by Shay Agroskin Committed by Saeed Mahameed Jan 25, 2019

net/mlx5e: Fix wrong private flag usage causing checksum disable



MLX5E_PFLAG_* definitions were changed from bitmask to enumerated
values. However, in mlx5e_open_rq(), the proper API (MLX5E_GET_PFLAG macro)
was not used to read the flag value of MLX5E_PFLAG_RX_NO_CSUM_COMPLETE.
Fixed it.

Fixes: 8ff57c18 ("net/mlx5e: Improve ethtool private-flags code structure")
Signed-off-by: Shay Agroskin <shayag@mellanox.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>

parent 4e046de0

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -950,7 +950,7 @@ static int mlx5e_open_rq(struct mlx5e_channel *c,
		if (params->rx_dim_enabled)
		__set_bit(MLX5E_RQ_STATE_AM, &c->rq.state);

		if (params->pflags & MLX5E_PFLAG_RX_NO_CSUM_COMPLETE)
		if (MLX5E_GET_PFLAG(params, MLX5E_PFLAG_RX_NO_CSUM_COMPLETE))
		__set_bit(MLX5E_RQ_STATE_NO_CSUM_COMPLETE, &c->rq.state);

		return 0;

Admin message