Commit 92ace482 authored May 07, 2020 by Bruce Allan Committed by Jeff Kirsher May 21, 2020

ice: remove unnecessary expression that is always true



The else conditional expression is always true due to the if conditional
expression; remove it and add a comment to make it obvious still.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 757976ab

drivers/net/ethernet/intel/ice/ice_main.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -346,7 +346,8 @@ static int ice_vsi_sync_fltr(struct ice_vsi *vsi)
		vsi->current_netdev_flags &= ~IFF_ALLMULTI;
		goto out_promisc;
		}
		} else if (!(vsi->current_netdev_flags & IFF_ALLMULTI)) {
		} else {
		/* !(vsi->current_netdev_flags & IFF_ALLMULTI) */
		if (vsi->vlan_ena)
		promisc_m = ICE_MCAST_VLAN_PROMISC_BITS;
		else

Admin message