Commit 9291c65b authored by Hans de Goede's avatar Hans de Goede Committed by Linus Walleij
Browse files

pinctrl: baytrail: Enable glitch filter for GPIOs used as interrupts 



On some systems, some PCB traces attached to GpioInts are routed in such
a way that they pick up enough interference to constantly (many times per
second) trigger.

Enabling glitch-filtering fixes this.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Acked-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 659e7142

drivers/pinctrl/intel/pinctrl-baytrail.c

+6 −0
Original line number Diff line number Diff line
@@ -46,6 +46,9 @@ 
#define BYT_TRIG_POS		BIT(25)

#define BYT_TRIG_LVL		BIT(24)

#define BYT_DEBOUNCE_EN		BIT(20)

#define BYT_GLITCH_FILTER_EN	BIT(19)

#define BYT_GLITCH_F_SLOW_CLK	BIT(17)

#define BYT_GLITCH_F_FAST_CLK	BIT(16)

#define BYT_PULL_STR_SHIFT	9

#define BYT_PULL_STR_MASK	(3 << BYT_PULL_STR_SHIFT)

#define BYT_PULL_STR_2K		(0 << BYT_PULL_STR_SHIFT)
@@ -1579,6 +1582,9 @@ static int byt_irq_type(struct irq_data *d, unsigned int type) 
	 */

	value &= ~(BYT_DIRECT_IRQ_EN | BYT_TRIG_POS | BYT_TRIG_NEG |

		   BYT_TRIG_LVL);

	/* Enable glitch filtering */

	value |= BYT_GLITCH_FILTER_EN | BYT_GLITCH_F_SLOW_CLK |

		 BYT_GLITCH_F_FAST_CLK;



	writel(value, reg);

CRA Git | Maintained and supported by SUSTech CRA and CCSE