Commit 927353a7 authored Mar 08, 2012 by Paul Gortmaker Committed by Greg Kroah-Hartman Mar 09, 2012

serial: introduce generic port in/out helpers



Looking at the existing serial drivers (esp. the 8250 derived
variants) we see a common trend.  They create a hardware specific
port struct, which in turn contains a generic serial_port struct.

The other trend, is that they all create some sort of shortcut
to go through the hardware specific struct, to the serial_port
struct, which has the basic in/out operations within.  Looking
for the serial_in and serial_out in several drivers shows this.

Rather than let this continue, lets create a generic set of
similar helper wrappers that can be used on a struct port, so
we can eliminate bouncing out through hardware specific struct
pointers just to come back into struct port where possible.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent dfe42443

include/linux/serial_core.h

+10 −0

Original line number	Diff line number	Diff line
		@@ -383,6 +383,16 @@ struct uart_port {
		void private_data; / generic platform data pointer */
		};

		static inline int serial_port_in(struct uart_port *up, int offset)
		{
		return up->serial_in(up, offset);
		}

		static inline void serial_port_out(struct uart_port *up, int offset, int value)
		{
		up->serial_out(up, offset, value);
		}

		/*
		* This is the state information which is persistent across opens.
		*/

Admin message