ACPI: delete obsolete "bus master activity" proc field (92614610) · Commits · 戴 / test

Linux-2.6.29 deleted the legacy ACPI idle handler, leaving the CPU_IDLE handler, which does not track bus master activity. So delete the unused bm_activity field -- it is confusing to print an always zero value. This patch could break programs that parse /proc/acpi/processor/*/power, since it deletes this line from that file: bus master activity: 00000000 http://bugzilla.kernel.org/show_bug.cgi?id=13145 is not fixed by this patch, but provoked this patch. Signed-off-by:

Len Brown <len.brown@intel.com>

drivers/acpi/processor_idle.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -662,11 +662,9 @@ static int acpi_processor_power_seq_show(struct seq_file seq, void offset)

		seq_printf(seq, "active state: C%zd\n"
		"max_cstate: C%d\n"
		"bus master activity: %08x\n"
		"maximum allowed latency: %d usec\n",
		pr->power.state ? pr->power.state - pr->power.states : 0,
		max_cstate, (unsigned)pr->power.bm_activity,
		pm_qos_requirement(PM_QOS_CPU_DMA_LATENCY));
		max_cstate, pm_qos_requirement(PM_QOS_CPU_DMA_LATENCY));

		seq_puts(seq, "states:\n");

include/acpi/processor.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -84,7 +84,6 @@ struct acpi_processor_power {
		struct acpi_processor_cx *state;
		unsigned long bm_check_timestamp;
		u32 default_state;
		u32 bm_activity;
		int count;
		struct acpi_processor_cx states[ACPI_PROCESSOR_MAX_POWER];
		int timer_broadcast_on_state;

Admin message