Commit 924de3b8 authored by Eric W. Biederman's avatar Eric W. Biederman
Browse files

fork: Have new threads join on-going signal group stops 



There are only two signals that are delivered to every member of a
signal group: SIGSTOP and SIGKILL.  Signal delivery requires every
signal appear to be delivered either before or after a clone syscall.
SIGKILL terminates the clone so does not need to be considered.  Which
leaves only SIGSTOP that needs to be considered when creating new
threads.

Today in the event of a group stop TIF_SIGPENDING will get set and the
fork will restart ensuring the fork syscall participates in the group
stop.

A fork (especially of a process with a lot of memory) is one of the
most expensive system so we really only want to restart a fork when
necessary.

It is easy so check to see if a SIGSTOP is ongoing and have the new
thread join it immediate after the clone completes.  Making it appear
the clone completed happened just before the SIGSTOP.

The calculate_sigpending function will see the bits set in jobctl and
set TIF_SIGPENDING to ensure the new task takes the slow path to userspace.

V2: The call to task_join_group_stop was moved before the new task is
    added to the thread group list.  This should not matter as
    sighand->siglock is held over both the addition of the threads,
    the call to task_join_group_stop and do_signal_stop.  But the change
    is trivial and it is one less thing to worry about when reading
    the code.

Signed-off-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
parent 4390e9ea

include/linux/sched/signal.h

+2 −0
Original line number Diff line number Diff line
@@ -385,6 +385,8 @@ static inline void ptrace_signal_wake_up(struct task_struct *t, bool resume) 
	signal_wake_up_state(t, resume ? __TASK_TRACED : 0);

}



void task_join_group_stop(struct task_struct *task);



#ifdef TIF_RESTORE_SIGMASK

/*

 * Legacy restore_sigmask accessors.  These are inefficient on

kernel/fork.c

+15 −12
Original line number Diff line number Diff line
@@ -1934,6 +1934,7 @@ static __latent_entropy struct task_struct *copy_process( 
		goto bad_fork_cancel_cgroup;

	}



	if (!(clone_flags & CLONE_THREAD)) {

		/*

		 * Process group and session signals need to be delivered to just the

		 * parent before the fork or both the parent and the child after the
@@ -1947,6 +1948,7 @@ static __latent_entropy struct task_struct *copy_process( 
			retval = -ERESTARTNOINTR;

			goto bad_fork_cancel_cgroup;

		}

	}





	init_task_pid_links(p);
@@ -1982,6 +1984,7 @@ static __latent_entropy struct task_struct *copy_process( 
			current->signal->nr_threads++;

			atomic_inc(&current->signal->live);

			atomic_inc(&current->signal->sigcnt);

			task_join_group_stop(p);

			list_add_tail_rcu(&p->thread_group,

					  &p->group_leader->thread_group);

			list_add_tail_rcu(&p->thread_node,

kernel/signal.c

+14 −0
Original line number Diff line number Diff line
@@ -373,6 +373,20 @@ static bool task_participate_group_stop(struct task_struct *task) 
	return false;

}



void task_join_group_stop(struct task_struct *task)

{

	/* Have the new thread join an on-going signal group stop */

	unsigned long jobctl = current->jobctl;

	if (jobctl & JOBCTL_STOP_PENDING) {

		struct signal_struct *sig = current->signal;

		unsigned long signr = jobctl & JOBCTL_STOP_SIGMASK;

		unsigned long gstop = JOBCTL_STOP_PENDING | JOBCTL_STOP_CONSUME;

		if (task_set_jobctl_pending(task, signr | gstop)) {

			sig->group_stop_count++;

		}

	}

}



/*

 * allocate a new signal queue record

 * - this may be called without locks if and only if t == current, otherwise an

CRA Git | Maintained and supported by SUSTech CRA and CCSE