Commit 922aa210 authored Aug 25, 2009 by Joe Eykholt Committed by James Bottomley Sep 10, 2009

[SCSI] libfc: fix RPORT_TO_PRIV and PRIV_TO_RPORT() macros.



These macros introduce extra undesirable semicolons that keep
them from being used in expressions, and they don't protect
against being passed an expression.

Add parens and remove the semicolons.

Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>

parent 795d86f5

include/scsi/libfc.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -223,9 +223,9 @@ struct fc_rport_libfc_priv {
		};

		#define PRIV_TO_RPORT(x) \
		(struct fc_rport )((void )x - sizeof(struct fc_rport));
		((struct fc_rport )((void )(x) - sizeof(struct fc_rport)))
		#define RPORT_TO_PRIV(x) \
		(struct fc_rport_libfc_priv )((void )x + sizeof(struct fc_rport));
		((struct fc_rport_libfc_priv )((void )(x) + sizeof(struct fc_rport)))

		static inline void fc_rport_set_name(struct fc_rport *rport, u64 wwpn, u64 wwnn)
		{

Admin message