Commit 9222a9cf authored Jun 12, 2013 by Dave Chinner Committed by Ben Myers Jun 14, 2013

xfs: don't shutdown log recovery on validation errors



Unfortunately, we cannot guarantee that items logged multiple times
and replayed by log recovery do not take objects back in time. When
they are taken back in time, the go into an intermediate state which
is corrupt, and hence verification that occurs on this intermediate
state causes log recovery to abort with a corruption shutdown.

Instead of causing a shutdown and unmountable filesystem, don't
verify post-recovery items before they are written to disk. This is
less than optimal, but there is no way to detect this issue for
non-CRC filesystems If log recovery successfully completes, this
will be undone and the object will be consistent by subsequent
transactions that are replayed, so in most cases we don't need to
take drastic action.

For CRC enabled filesystems, leave the verifiers in place - we need
to call them to recalculate the CRCs on the objects anyway. This
recovery problem can be solved for such filesystems - we have a LSN
stamped in all metadata at writeback time that we can to determine
whether the item should be replayed or not. This is a separate piece
of work, so is not addressed by this patch.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>

parent ade1335a

fs/xfs/xfs_log_recover.c

+17 −2

Original line number	Diff line number	Diff line
		@@ -1845,6 +1845,12 @@ xlog_recover_do_inode_buffer(
		xfs_agino_t *buffer_nextp;

		trace_xfs_log_recover_buf_inode_buf(mp->m_log, buf_f);

		/*
		* Post recovery validation only works properly on CRC enabled
		* filesystems.
		*/
		if (xfs_sb_version_hascrc(&mp->m_sb))
		bp->b_ops = &xfs_inode_buf_ops;

		inodes_per_buf = BBTOB(bp->b_io_length) >> mp->m_sb.sb_inodelog;
		@@ -2205,6 +2211,15 @@ xlog_recover_do_reg_buffer(
		/* Shouldn't be any more regions */
		ASSERT(i == item->ri_total);

		/*
		* We can only do post recovery validation on items on CRC enabled
		* fielsystems as we need to know when the buffer was written to be able
		* to determine if we should have replayed the item. If we replay old
		* metadata over a newer buffer, then it will enter a temporarily
		* inconsistent state resulting in verification failures. Hence for now
		* just avoid the verification stage for non-crc filesystems
		*/
		if (xfs_sb_version_hascrc(&mp->m_sb))
		xlog_recovery_validate_buf_type(mp, bp, buf_f);
		}

Admin message