Commit 9213784b authored by Paul E. McKenney's avatar Paul E. McKenney
Browse files

rcu: Eliminate BUG_ON() for kernel/rcu/tree_plugin.h 



The tree_plugin.h file has a number of calls to BUG_ON(), which panics
the kernel, which is not a good strategy for devices (like embedded)
that don't have a way to capture console output.  This commit therefore
converts these BUG_ON() calls to WARN_ON_ONCE() and WARN_ONCE().

Reported-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.ibm.com>
[ paulmck: Fix typo: s/rcuo/rcub/. ]
parent 08543bda

kernel/rcu/tree_plugin.h

+6 −3
Original line number Diff line number Diff line
@@ -1464,7 +1464,8 @@ static void __init rcu_spawn_boost_kthreads(void) 


	for_each_possible_cpu(cpu)

		per_cpu(rcu_cpu_has_work, cpu) = 0;

	BUG_ON(smpboot_register_percpu_thread(&rcu_cpu_thread_spec));

	if (WARN_ONCE(smpboot_register_percpu_thread(&rcu_cpu_thread_spec), "%s: Could not start rcub kthread, OOM is now expected behavior\n", __func__))

		return;

	rcu_for_each_leaf_node(rnp)

		(void)rcu_spawn_one_boost_kthread(rnp);

}
@@ -2322,7 +2323,8 @@ static int rcu_nocb_kthread(void *arg) 
		tail = rdp->nocb_follower_tail;

		rdp->nocb_follower_tail = &rdp->nocb_follower_head;

		raw_spin_unlock_irqrestore(&rdp->nocb_lock, flags);

		BUG_ON(!list);

		if (WARN_ON_ONCE(!list))

			continue;

		trace_rcu_nocb_wake(rcu_state.name, rdp->cpu, TPS("WokeNonEmpty"));



		/* Each pass through the following loop invokes a callback. */
@@ -2495,7 +2497,8 @@ static void rcu_spawn_one_nocb_kthread(int cpu) 
	/* Spawn the kthread for this CPU. */

	t = kthread_run(rcu_nocb_kthread, rdp_spawn,

			"rcuo%c/%d", rcu_state.abbr, cpu);

	BUG_ON(IS_ERR(t));

	if (WARN_ONCE(IS_ERR(t), "%s: Could not start rcuo kthread, OOM is now expected behavior\n", __func__))

		return;

	WRITE_ONCE(rdp_spawn->nocb_kthread, t);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE