Commit 92128236 authored by Takashi Sakamoto's avatar Takashi Sakamoto Committed by Takashi Iwai
Browse files

ALSA: firewire-tascam: enclose identifiers referred by single function 



Some identifiers are referred just by one functions. In this case, they
can be put into the function definition. This brings two merits; readers
can easily follow codes related to the identifiers, developers are free
from name conflict.

This commit moves such identifiers to each function definition.

Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent a4e86cba

sound/firewire/tascam/tascam-hwdep.c

+8 −9
Original line number Diff line number Diff line
@@ -163,16 +163,15 @@ static int hwdep_compat_ioctl(struct snd_hwdep *hwdep, struct file *file, 
#define hwdep_compat_ioctl NULL

#endif



static const struct snd_hwdep_ops hwdep_ops = {

int snd_tscm_create_hwdep_device(struct snd_tscm *tscm)

{

	static const struct snd_hwdep_ops ops = {

		.read		= hwdep_read,

		.release	= hwdep_release,

		.poll		= hwdep_poll,

		.ioctl		= hwdep_ioctl,

		.ioctl_compat	= hwdep_compat_ioctl,

	};



int snd_tscm_create_hwdep_device(struct snd_tscm *tscm)

{

	struct snd_hwdep *hwdep;

	int err;
@@ -182,7 +181,7 @@ int snd_tscm_create_hwdep_device(struct snd_tscm *tscm) 


	strcpy(hwdep->name, "Tascam");

	hwdep->iface = SNDRV_HWDEP_IFACE_FW_TASCAM;

	hwdep->ops = hwdep_ops;

	hwdep->ops = ops;

	hwdep->private_data = tscm;

	hwdep->exclusive = true;

sound/firewire/tascam/tascam-midi.c

+12 −14
Original line number Diff line number Diff line
@@ -68,20 +68,18 @@ static void midi_playback_trigger(struct snd_rawmidi_substream *substrm, int up) 
	spin_unlock_irqrestore(&tscm->lock, flags);

}



static struct snd_rawmidi_ops midi_capture_ops = {

int snd_tscm_create_midi_devices(struct snd_tscm *tscm)

{

	static struct snd_rawmidi_ops capture_ops = {

		.open		= midi_capture_open,

		.close		= midi_capture_close,

		.trigger	= midi_capture_trigger,

	};



static struct snd_rawmidi_ops midi_playback_ops = {

	static struct snd_rawmidi_ops playback_ops = {

		.open		= midi_playback_open,

		.close		= midi_playback_close,

		.trigger	= midi_playback_trigger,

	};



int snd_tscm_create_midi_devices(struct snd_tscm *tscm)

{

	struct snd_rawmidi *rmidi;

	struct snd_rawmidi_str *stream;

	struct snd_rawmidi_substream *subs;
@@ -100,7 +98,7 @@ int snd_tscm_create_midi_devices(struct snd_tscm *tscm) 


	rmidi->info_flags |= SNDRV_RAWMIDI_INFO_INPUT;

	snd_rawmidi_set_ops(rmidi, SNDRV_RAWMIDI_STREAM_INPUT,

			    &midi_capture_ops);

			    &capture_ops);

	stream = &rmidi->streams[SNDRV_RAWMIDI_STREAM_INPUT];



	/* Set port names for MIDI input. */
@@ -116,7 +114,7 @@ int snd_tscm_create_midi_devices(struct snd_tscm *tscm) 


	rmidi->info_flags |= SNDRV_RAWMIDI_INFO_OUTPUT;

	snd_rawmidi_set_ops(rmidi, SNDRV_RAWMIDI_STREAM_OUTPUT,

			    &midi_playback_ops);

			    &playback_ops);

	stream = &rmidi->streams[SNDRV_RAWMIDI_STREAM_OUTPUT];



	/* Set port names for MIDI ourput. */

sound/firewire/tascam/tascam-pcm.c

+25 −27
Original line number Diff line number Diff line
@@ -268,7 +268,9 @@ static snd_pcm_uframes_t pcm_playback_pointer(struct snd_pcm_substream *sbstrm) 
	return amdtp_stream_pcm_pointer(&tscm->rx_stream);

}



static const struct snd_pcm_ops pcm_capture_ops = {

int snd_tscm_create_pcm_devices(struct snd_tscm *tscm)

{

	static const struct snd_pcm_ops capture_ops = {

		.open		= pcm_open,

		.close		= pcm_close,

		.ioctl		= snd_pcm_lib_ioctl,
@@ -279,8 +281,7 @@ static const struct snd_pcm_ops pcm_capture_ops = { 
		.pointer	= pcm_capture_pointer,

		.page		= snd_pcm_lib_get_vmalloc_page,

	};



static const struct snd_pcm_ops pcm_playback_ops = {

	static const struct snd_pcm_ops playback_ops = {

		.open		= pcm_open,

		.close		= pcm_close,

		.ioctl		= snd_pcm_lib_ioctl,
@@ -292,9 +293,6 @@ static const struct snd_pcm_ops pcm_playback_ops = { 
		.page		= snd_pcm_lib_get_vmalloc_page,

		.mmap		= snd_pcm_lib_mmap_vmalloc,

	};



int snd_tscm_create_pcm_devices(struct snd_tscm *tscm)

{

	struct snd_pcm *pcm;

	int err;
@@ -305,8 +303,8 @@ int snd_tscm_create_pcm_devices(struct snd_tscm *tscm) 
	pcm->private_data = tscm;

	snprintf(pcm->name, sizeof(pcm->name),

		 "%s PCM", tscm->card->shortname);

	snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &pcm_playback_ops);

	snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &pcm_capture_ops);

	snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &playback_ops);

	snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &capture_ops);



	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE