Commit 921195d3 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi 

Pull SCSI fixes from James Bottomley:
 "Eight fixes.

  The most important one is the mpt3sas fix which makes the driver work
  again on big endian systems. The rest are mostly minor error path or
  checker issues and the vmw_scsi one fixes a performance problem"

* tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi:
  scsi: vmw_pvscsi: Return DID_RESET for status SAM_STAT_COMMAND_TERMINATED
  scsi: sr: Avoid that opening a CD-ROM hangs with runtime power management enabled
  scsi: mpt3sas: Swap I/O memory read value back to cpu endianness
  scsi: fcoe: clear FC_RP_STARTED flags when receiving a LOGO
  scsi: fcoe: drop frames in ELS LOGO error path
  scsi: fcoe: fix use-after-free in fcoe_ctlr_els_send
  scsi: qedi: Fix a potential buffer overflow
  scsi: qla2xxx: Fix memory leak for allocating abort IOCB
parents b5b1404d e95153b6

drivers/scsi/fcoe/fcoe_ctlr.c

+3 −3
Original line number Diff line number Diff line
@@ -754,9 +754,9 @@ int fcoe_ctlr_els_send(struct fcoe_ctlr *fip, struct fc_lport *lport, 
	case ELS_LOGO:

		if (fip->mode == FIP_MODE_VN2VN) {

			if (fip->state != FIP_ST_VNMP_UP)

				return -EINVAL;

				goto drop;

			if (ntoh24(fh->fh_d_id) == FC_FID_FLOGI)

				return -EINVAL;

				goto drop;

		} else {

			if (fip->state != FIP_ST_ENABLED)

				return 0;
@@ -799,9 +799,9 @@ int fcoe_ctlr_els_send(struct fcoe_ctlr *fip, struct fc_lport *lport, 
	fip->send(fip, skb);

	return -EINPROGRESS;

drop:

	kfree_skb(skb);

	LIBFCOE_FIP_DBG(fip, "drop els_send op %u d_id %x\n",

			op, ntoh24(fh->fh_d_id));

	kfree_skb(skb);

	return -EINVAL;

}

EXPORT_SYMBOL(fcoe_ctlr_els_send);

drivers/scsi/libfc/fc_rport.c

+1 −0
Original line number Diff line number Diff line
@@ -2164,6 +2164,7 @@ static void fc_rport_recv_logo_req(struct fc_lport *lport, struct fc_frame *fp) 
		FC_RPORT_DBG(rdata, "Received LOGO request while in state %s\n",

			     fc_rport_state(rdata));



		rdata->flags &= ~FC_RP_STARTED;

		fc_rport_enter_delete(rdata, RPORT_EV_STOP);

		mutex_unlock(&rdata->rp_mutex);

		kref_put(&rdata->kref, fc_rport_destroy);

drivers/scsi/mpt3sas/mpt3sas_base.c

+8 −8
Original line number Diff line number Diff line
@@ -3343,11 +3343,10 @@ _base_mpi_ep_writeq(__u64 b, volatile void __iomem *addr, 
					spinlock_t *writeq_lock)

{

	unsigned long flags;

	__u64 data_out = b;



	spin_lock_irqsave(writeq_lock, flags);

	writel((u32)(data_out), addr);

	writel((u32)(data_out >> 32), (addr + 4));

	__raw_writel((u32)(b), addr);

	__raw_writel((u32)(b >> 32), (addr + 4));

	mmiowb();

	spin_unlock_irqrestore(writeq_lock, flags);

}
@@ -3367,7 +3366,8 @@ _base_mpi_ep_writeq(__u64 b, volatile void __iomem *addr, 
static inline void

_base_writeq(__u64 b, volatile void __iomem *addr, spinlock_t *writeq_lock)

{

	writeq(b, addr);

	__raw_writeq(b, addr);

	mmiowb();

}

#else

static inline void
@@ -5268,7 +5268,7 @@ _base_handshake_req_reply_wait(struct MPT3SAS_ADAPTER *ioc, int request_bytes, 


	/* send message 32-bits at a time */

	for (i = 0, failed = 0; i < request_bytes/4 && !failed; i++) {

		writel((u32)(request[i]), &ioc->chip->Doorbell);

		writel(cpu_to_le32(request[i]), &ioc->chip->Doorbell);

		if ((_base_wait_for_doorbell_ack(ioc, 5)))

			failed = 1;

	}
@@ -5289,7 +5289,7 @@ _base_handshake_req_reply_wait(struct MPT3SAS_ADAPTER *ioc, int request_bytes, 
	}



	/* read the first two 16-bits, it gives the total length of the reply */

	reply[0] = (u16)(readl(&ioc->chip->Doorbell)

	reply[0] = le16_to_cpu(readl(&ioc->chip->Doorbell)

	    & MPI2_DOORBELL_DATA_MASK);

	writel(0, &ioc->chip->HostInterruptStatus);

	if ((_base_wait_for_doorbell_int(ioc, 5))) {
@@ -5298,7 +5298,7 @@ _base_handshake_req_reply_wait(struct MPT3SAS_ADAPTER *ioc, int request_bytes, 
			ioc->name, __LINE__);

		return -EFAULT;

	}

	reply[1] = (u16)(readl(&ioc->chip->Doorbell)

	reply[1] = le16_to_cpu(readl(&ioc->chip->Doorbell)

	    & MPI2_DOORBELL_DATA_MASK);

	writel(0, &ioc->chip->HostInterruptStatus);
@@ -5312,7 +5312,7 @@ _base_handshake_req_reply_wait(struct MPT3SAS_ADAPTER *ioc, int request_bytes, 
		if (i >=  reply_bytes/2) /* overflow case */

			readl(&ioc->chip->Doorbell);

		else

			reply[i] = (u16)(readl(&ioc->chip->Doorbell)

			reply[i] = le16_to_cpu(readl(&ioc->chip->Doorbell)

			    & MPI2_DOORBELL_DATA_MASK);

		writel(0, &ioc->chip->HostInterruptStatus);

	}

drivers/scsi/qedi/qedi_main.c

+1 −1
Original line number Diff line number Diff line
@@ -888,7 +888,7 @@ static void qedi_get_boot_tgt_info(struct nvm_iscsi_block *block, 
	ipv6_en = !!(block->generic.ctrl_flags &

		     NVM_ISCSI_CFG_GEN_IPV6_ENABLED);



	snprintf(tgt->iscsi_name, NVM_ISCSI_CFG_ISCSI_NAME_MAX_LEN, "%s\n",

	snprintf(tgt->iscsi_name, sizeof(tgt->iscsi_name), "%s\n",

		 block->target[index].target_name.byte);



	tgt->ipv6_en = ipv6_en;

drivers/scsi/qla2xxx/qla_iocb.c

+27 −26
Original line number Diff line number Diff line
@@ -2130,34 +2130,11 @@ __qla2x00_alloc_iocbs(struct qla_qpair *qpair, srb_t *sp) 
	req_cnt = 1;

	handle = 0;



	if (!sp)

		goto skip_cmd_array;



	/* Check for room in outstanding command list. */

	handle = req->current_outstanding_cmd;

	for (index = 1; index < req->num_outstanding_cmds; index++) {

		handle++;

		if (handle == req->num_outstanding_cmds)

			handle = 1;

		if (!req->outstanding_cmds[handle])

			break;

	}

	if (index == req->num_outstanding_cmds) {

		ql_log(ql_log_warn, vha, 0x700b,

		    "No room on outstanding cmd array.\n");

		goto queuing_error;

	}



	/* Prep command array. */

	req->current_outstanding_cmd = handle;

	req->outstanding_cmds[handle] = sp;

	sp->handle = handle;



	if (sp && (sp->type != SRB_SCSI_CMD)) {

		/* Adjust entry-counts as needed. */

	if (sp->type != SRB_SCSI_CMD)

		req_cnt = sp->iocbs;

	}



skip_cmd_array:

	/* Check for room on request queue. */

	if (req->cnt < req_cnt + 2) {

		if (qpair->use_shadow_reg)
@@ -2183,6 +2160,28 @@ skip_cmd_array: 
	if (req->cnt < req_cnt + 2)

		goto queuing_error;



	if (sp) {

		/* Check for room in outstanding command list. */

		handle = req->current_outstanding_cmd;

		for (index = 1; index < req->num_outstanding_cmds; index++) {

			handle++;

			if (handle == req->num_outstanding_cmds)

				handle = 1;

			if (!req->outstanding_cmds[handle])

				break;

		}

		if (index == req->num_outstanding_cmds) {

			ql_log(ql_log_warn, vha, 0x700b,

			    "No room on outstanding cmd array.\n");

			goto queuing_error;

		}



		/* Prep command array. */

		req->current_outstanding_cmd = handle;

		req->outstanding_cmds[handle] = sp;

		sp->handle = handle;

	}



	/* Prep packet */

	req->cnt -= req_cnt;

	pkt = req->ring_ptr;
@@ -2195,6 +2194,8 @@ skip_cmd_array: 
		pkt->handle = handle;

	}



	return pkt;



queuing_error:

	qpair->tgt_counters.num_alloc_iocb_failed++;

	return pkt;

CRA Git | Maintained and supported by SUSTech CRA and CCSE