Commit 920bce20 authored Aug 13, 2014 by Milosz Tanski Committed by David Howells Aug 27, 2014

FS-Cache: Reduce cookie ref count if submit fails.



I've been seeing issues with disposing cookies under vma pressure. The symptom
is that the refcount gets out of sync. In this case we fail to decrement the
refcount if submit fails. I found this while auditing the error in and around
cookie operations.

Signed-off-by: Milosz Tanski <milosz@adfin.com>
Signed-off-by: David Howells <dhowells@redhat.com>

parent 9776de96

fs/fscache/object.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -982,6 +982,7 @@ nomem:
		submit_op_failed:
		clear_bit(FSCACHE_OBJECT_IS_LIVE, &object->flags);
		spin_unlock(&cookie->lock);
		fscache_unuse_cookie(object);
		kfree(op);
		_leave(" [EIO]");
		return transit_to(KILL_OBJECT);

Admin message