Commit 91bca7f7 authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

Merge branch 'devlink-add-reload-action-and-limit-options' 



Moshe Shemesh says:

====================
Add devlink reload action and limit options

Introduce new options on devlink reload API to enable the user to select
the reload action required and constrains limits on these actions that he
may want to ensure. Complete support for reload actions in mlx5.
The following reload actions are supported:
  driver_reinit: driver entities re-initialization, applying devlink-param
                 and devlink-resource values.
  fw_activate: firmware activate.

The uAPI is backward compatible, if the reload action option is omitted
from the reload command, the driver reinit action will be used.
Note that when required to do firmware activation some drivers may need
to reload the driver. On the other hand some drivers may need to reset
the firmware to reinitialize the driver entities. Therefore, the devlink
reload command returns the actions which were actually performed.

By default reload actions are not limited and driver implementation may
include reset or downtime as needed to perform the actions.
However, if reload limit is selected, the driver should perform only if
it can do it while keeping the limit constraints.
Reload limit added:
  no_reset: No reset allowed, no down time allowed, no link flap and no
            configuration is lost.

Each driver which supports devlink reload command should expose the
reload actions and limits supported.

Add reload stats to hold the history per reload action per limit.
For example, the number of times fw_activate has been done on this
device since the driver module was added or if the firmware activation
was done with or without reset.

Patch 1 changes devlink_reload_supported() param type to enable using
        it before allocating devlink.
Patch 2-3 add the new API reload action and reload limit options to
          devlink reload.
Patch 4-5 add reload stats and remote reload stats. These stats are
          exposed through devlink dev get.
Patches 6-11 add support on mlx5 for devlink reload action fw_activate
            and handle the firmware reset events.
Patches 12-13 add devlink enable remote dev reset parameter and use it
             in mlx5.
Patches 14-15 mlx5 add devlink reload limit no_reset support for
              fw_activate reload action.
Patch 16 adds documentation file devlink-reload.rst
====================

Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parents 846e463a eb79d754

Documentation/networking/devlink/devlink-params.rst

+6 −0
Original line number Diff line number Diff line
@@ -108,3 +108,9 @@ own name. 
   * - ``region_snapshot_enable``

     - Boolean

     - Enable capture of ``devlink-region`` snapshots.

   * - ``enable_remote_dev_reset``

     - Boolean

     - Enable device reset by remote host. When cleared, the device driver

       will NACK any attempt of other host to reset the device. This parameter

       is useful for setups where a device is shared by different hosts, such

       as multi-host setup.

Documentation/networking/devlink/devlink-reload.rst

0 → 100644
+81 −0
Original line number Diff line number Diff line 
.. SPDX-License-Identifier: GPL-2.0



==============

Devlink Reload

==============



``devlink-reload`` provides mechanism to reinit driver entities, applying

``devlink-params`` and ``devlink-resources`` new values. It also provides

mechanism to activate firmware.



Reload Actions

==============



User may select a reload action.

By default ``driver_reinit`` action is selected.



.. list-table:: Possible reload actions

   :widths: 5 90



   * - Name

     - Description

   * - ``driver-reinit``

     - Devlink driver entities re-initialization, including applying

       new values to devlink entities which are used during driver

       load such as ``devlink-params`` in configuration mode

       ``driverinit`` or ``devlink-resources``

   * - ``fw_activate``

     - Firmware activate. Activates new firmware if such image is stored and

       pending activation. If no limitation specified this action may involve

       firmware reset. If no new image pending this action will reload current

       firmware image.



Note that even though user asks for a specific action, the driver

implementation might require to perform another action alongside with

it. For example, some driver do not support driver reinitialization

being performed without fw activation. Therefore, the devlink reload

command returns the list of actions which were actrually performed.



Reload Limits

=============



By default reload actions are not limited and driver implementation may

include reset or downtime as needed to perform the actions.



However, some drivers support action limits, which limit the action

implementation to specific constraints.



.. list-table:: Possible reload limits

   :widths: 5 90



   * - Name

     - Description

   * - ``no_reset``

     - No reset allowed, no down time allowed, no link flap and no

       configuration is lost.



Change Namespace

================



The netns option allows user to be able to move devlink instances into

namespaces during devlink reload operation.

By default all devlink instances are created in init_net and stay there.



example usage

-------------



.. code:: shell



    $ devlink dev reload help

    $ devlink dev reload DEV [ netns { PID | NAME | ID } ] [ action { driver_reinit | fw_activate } ] [ limit no_reset ]



    # Run reload command for devlink driver entities re-initialization:

    $ devlink dev reload pci/0000:82:00.0 action driver_reinit

    reload_actions_performed:

      driver_reinit



    # Run reload command to activate firmware:

    # Note that mlx5 driver reloads the driver while activating firmware

    $ devlink dev reload pci/0000:82:00.0 action fw_activate

    reload_actions_performed:

      driver_reinit fw_activate

Documentation/networking/devlink/index.rst

+1 −0
Original line number Diff line number Diff line
@@ -20,6 +20,7 @@ general. 
   devlink-params

   devlink-region

   devlink-resource

   devlink-reload

   devlink-trap



Driver-specific documentation

drivers/net/ethernet/mellanox/mlx4/main.c

+6 −1
Original line number Diff line number Diff line
@@ -3946,6 +3946,8 @@ static int mlx4_restart_one_up(struct pci_dev *pdev, bool reload, 
			       struct devlink *devlink);



static int mlx4_devlink_reload_down(struct devlink *devlink, bool netns_change,

				    enum devlink_reload_action action,

				    enum devlink_reload_limit limit,

				    struct netlink_ext_ack *extack)

{

	struct mlx4_priv *priv = devlink_priv(devlink);
@@ -3962,7 +3964,8 @@ static int mlx4_devlink_reload_down(struct devlink *devlink, bool netns_change, 
	return 0;

}



static int mlx4_devlink_reload_up(struct devlink *devlink,

static int mlx4_devlink_reload_up(struct devlink *devlink, enum devlink_reload_action action,

				  enum devlink_reload_limit limit, u32 *actions_performed,

				  struct netlink_ext_ack *extack)

{

	struct mlx4_priv *priv = devlink_priv(devlink);
@@ -3970,6 +3973,7 @@ static int mlx4_devlink_reload_up(struct devlink *devlink, 
	struct mlx4_dev_persistent *persist = dev->persist;

	int err;



	*actions_performed = BIT(DEVLINK_RELOAD_ACTION_DRIVER_REINIT);

	err = mlx4_restart_one_up(persist->pdev, true, devlink);

	if (err)

		mlx4_err(persist->dev, "mlx4_restart_one_up failed, ret=%d\n",
@@ -3980,6 +3984,7 @@ static int mlx4_devlink_reload_up(struct devlink *devlink, 


static const struct devlink_ops mlx4_devlink_ops = {

	.port_type_set	= mlx4_devlink_port_type_set,

	.reload_actions = BIT(DEVLINK_RELOAD_ACTION_DRIVER_REINIT),

	.reload_down	= mlx4_devlink_reload_down,

	.reload_up	= mlx4_devlink_reload_up,

};

drivers/net/ethernet/mellanox/mlx5/core/Makefile

+1 −1
Original line number Diff line number Diff line
@@ -16,7 +16,7 @@ mlx5_core-y := main.o cmd.o debugfs.o fw.o eq.o uar.o pagealloc.o \ 
		transobj.o vport.o sriov.o fs_cmd.o fs_core.o pci_irq.o \

		fs_counters.o rl.o lag.o dev.o events.o wq.o lib/gid.o \

		lib/devcom.o lib/pci_vsc.o lib/dm.o diag/fs_tracepoint.o \

		diag/fw_tracer.o diag/crdump.o devlink.o diag/rsc_dump.o

		diag/fw_tracer.o diag/crdump.o devlink.o diag/rsc_dump.o fw_reset.o



#

# Netdev basic

CRA Git | Maintained and supported by SUSTech CRA and CCSE