Commit 91b0abe3 authored by Johannes Weiner's avatar Johannes Weiner Committed by Linus Torvalds
Browse files

mm + fs: store shadow entries in page cache 



Reclaim will be leaving shadow entries in the page cache radix tree upon
evicting the real page.  As those pages are found from the LRU, an
iput() can lead to the inode being freed concurrently.  At this point,
reclaim must no longer install shadow pages because the inode freeing
code needs to ensure the page tree is really empty.

Add an address_space flag, AS_EXITING, that the inode freeing code sets
under the tree lock before doing the final truncate.  Reclaim will check
for this flag before installing shadow pages.

Signed-off-by: default avatarJohannes Weiner <hannes@cmpxchg.org>
Reviewed-by: default avatarRik van Riel <riel@redhat.com>
Reviewed-by: default avatarMinchan Kim <minchan@kernel.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Bob Liu <bob.liu@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>
Cc: Greg Thelen <gthelen@google.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Jan Kara <jack@suse.cz>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Luigi Semenzato <semenzato@google.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Metin Doslu <metin@citusdata.com>
Cc: Michel Lespinasse <walken@google.com>
Cc: Ozgun Erdogan <ozgun@citusdata.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Roman Gushchin <klamm@yandex-team.ru>
Cc: Ryan Mallon <rmallon@gmail.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0cd6144a

Documentation/filesystems/porting

+3 −3
Original line number Diff line number Diff line
@@ -295,9 +295,9 @@ in the beginning of ->setattr unconditionally. 
	->clear_inode() and ->delete_inode() are gone; ->evict_inode() should

be used instead.  It gets called whenever the inode is evicted, whether it has

remaining links or not.  Caller does *not* evict the pagecache or inode-associated

metadata buffers; getting rid of those is responsibility of method, as it had

been for ->delete_inode(). Caller makes sure async writeback cannot be running

for the inode while (or after) ->evict_inode() is called.

metadata buffers; the method has to use truncate_inode_pages_final() to get rid

of those. Caller makes sure async writeback cannot be running for the inode while

(or after) ->evict_inode() is called.



	->drop_inode() returns int now; it's called on final iput() with

inode->i_lock held and it returns true if filesystems wants the inode to be

drivers/staging/lustre/lustre/llite/llite_lib.c

+1 −1
Original line number Diff line number Diff line
@@ -1877,7 +1877,7 @@ void ll_delete_inode(struct inode *inode) 
		cl_sync_file_range(inode, 0, OBD_OBJECT_EOF,

				   CL_FSYNC_DISCARD, 1);



	truncate_inode_pages(&inode->i_data, 0);

	truncate_inode_pages_final(&inode->i_data);



	/* Workaround for LU-118 */

	if (inode->i_data.nrpages) {

fs/9p/vfs_inode.c

+1 −1
Original line number Diff line number Diff line
@@ -451,7 +451,7 @@ void v9fs_evict_inode(struct inode *inode) 
{

	struct v9fs_inode *v9inode = V9FS_I(inode);



	truncate_inode_pages(inode->i_mapping, 0);

	truncate_inode_pages_final(inode->i_mapping);

	clear_inode(inode);

	filemap_fdatawrite(inode->i_mapping);

fs/affs/inode.c

+1 −1
Original line number Diff line number Diff line
@@ -259,7 +259,7 @@ affs_evict_inode(struct inode *inode) 
{

	unsigned long cache_page;

	pr_debug("AFFS: evict_inode(ino=%lu, nlink=%u)\n", inode->i_ino, inode->i_nlink);

	truncate_inode_pages(&inode->i_data, 0);

	truncate_inode_pages_final(&inode->i_data);



	if (!inode->i_nlink) {

		inode->i_size = 0;

fs/afs/inode.c

+1 −1
Original line number Diff line number Diff line
@@ -422,7 +422,7 @@ void afs_evict_inode(struct inode *inode) 


	ASSERTCMP(inode->i_ino, ==, vnode->fid.vnode);



	truncate_inode_pages(&inode->i_data, 0);

	truncate_inode_pages_final(&inode->i_data);

	clear_inode(inode);



	afs_give_up_callback(vnode);

CRA Git | Maintained and supported by SUSTech CRA and CCSE