Commit 91a90140 authored Jul 12, 2017 by Geert Uytterhoeven Committed by Linus Torvalds Jul 12, 2017

mm/memory.c: mark create_huge_pmd() inline to prevent build failure

With gcc 4.1.2:

    mm/memory.o: In function `create_huge_pmd':
    memory.c:(.text+0x93e): undefined reference to `do_huge_pmd_anonymous_page'

Interestingly, create_huge_pmd() is emitted in the assembler output, but
never called.

Converting transparent_hugepage_enabled() from a macro to a static
inline function reduced the ability of the compiler to remove unused
code.

Fix this by marking create_huge_pmd() inline.

Fixes: 16981d76 ("mm: improve readability of transparent_hugepage_enabled()")
Link: http://lkml.kernel.org/r/1499842660-10665-1-git-send-email-geert@linux-m68k.org


Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent c7acec71

mm/memory.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3591,7 +3591,7 @@ out:
		return 0;
		}

		static int create_huge_pmd(struct vm_fault *vmf)
		static inline int create_huge_pmd(struct vm_fault *vmf)
		{
		if (vma_is_anonymous(vmf->vma))
		return do_huge_pmd_anonymous_page(vmf);

Admin message