Commit 91a7d4bf authored Jan 30, 2020 by Nathan Chancellor Committed by Jakub Kicinski Jan 31, 2020

mlxsw: spectrum_qdisc: Fix 64-bit division error in mlxsw_sp_qdisc_tbf_rate_kbps



When building arm32 allmodconfig:

ERROR: "__aeabi_uldivmod"
[drivers/net/ethernet/mellanox/mlxsw/mlxsw_spectrum.ko] undefined!

rate_bytes_ps has type u64, we need to use a 64-bit division helper to
avoid a build error.

Fixes: a44f58c4 ("mlxsw: spectrum_qdisc: Support offloading of TBF Qdisc")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Tested-by: Ido Schimmel <idosch@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent b5ce31b5

drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -614,7 +614,7 @@ mlxsw_sp_qdisc_tbf_rate_kbps(struct tc_tbf_qopt_offload_replace_params *p)
		/* TBF interface is in bytes/s, whereas Spectrum ASIC is configured in
		* Kbits/s.
		*/
		return p->rate.rate_bytes_ps / 1000 * 8;
		return div_u64(p->rate.rate_bytes_ps, 1000) * 8;
		}

		static int

Admin message