Commit 916a3c65 authored by Andre Guedes's avatar Andre Guedes Committed by Jeff Kirsher
Browse files

igc: Use netdev log helpers in igc_ptp.c 



In igc_ptp.c we print log messages using dev_* helpers, generating
inconsistent output with the rest of the driver. Since this is a network
device driver, we should preferably use netdev_* helpers because they
append the interface name to the message, helping making sense out of
the logs.

This patch converts all dev_* calls to netdev_*.

Signed-off-by: default avatarAndre Guedes <andre.guedes@intel.com>
Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 95f96a9f

drivers/net/ethernet/intel/igc/igc_ptp.c

+5 −7
Original line number Diff line number Diff line
@@ -466,7 +466,7 @@ void igc_ptp_tx_hang(struct igc_adapter *adapter) 
		 * interrupt

		 */

		rd32(IGC_TXSTMPH);

		dev_warn(&adapter->pdev->dev, "clearing Tx timestamp hang\n");

		netdev_warn(adapter->netdev, "Clearing Tx timestamp hang\n");

	}

}
@@ -529,7 +529,7 @@ static void igc_ptp_tx_work(struct work_struct *work) 
		 * interrupt

		 */

		rd32(IGC_TXSTMPH);

		dev_warn(&adapter->pdev->dev, "clearing Tx timestamp hang\n");

		netdev_warn(adapter->netdev, "Clearing Tx timestamp hang\n");

		return;

	}
@@ -626,10 +626,9 @@ void igc_ptp_init(struct igc_adapter *adapter) 
						&adapter->pdev->dev);

	if (IS_ERR(adapter->ptp_clock)) {

		adapter->ptp_clock = NULL;

		dev_err(&adapter->pdev->dev, "ptp_clock_register failed\n");

		netdev_err(netdev, "ptp_clock_register failed\n");

	} else if (adapter->ptp_clock) {

		dev_info(&adapter->pdev->dev, "added PHC on %s\n",

			 adapter->netdev->name);

		netdev_info(netdev, "PHC added\n");

		adapter->ptp_flags |= IGC_PTP_ENABLED;

	}

}
@@ -666,8 +665,7 @@ void igc_ptp_stop(struct igc_adapter *adapter) 


	if (adapter->ptp_clock) {

		ptp_clock_unregister(adapter->ptp_clock);

		dev_info(&adapter->pdev->dev, "removed PHC on %s\n",

			 adapter->netdev->name);

		netdev_info(adapter->netdev, "PHC removed\n");

		adapter->ptp_flags &= ~IGC_PTP_ENABLED;

	}

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE