Commit 9167b0b9 authored Aug 22, 2006 by Trond Myklebust

VFS: Remove redundant open-coded mode bit check in prepare_binfmt().



The check in prepare_binfmt() for inode->i_mode & 0111 is redundant,
since open_exec() will already have done that.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
(cherry picked from 822dec482ced07af32c378cd936d77345786572b commit)

parent a343bb77

fs/exec.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -922,12 +922,6 @@ int prepare_binprm(struct linux_binprm *bprm)
		int retval;

		mode = inode->i_mode;
		/*
		* Check execute perms again - if the caller has CAP_DAC_OVERRIDE,
		* generic_permission lets a non-executable through
		*/
		if (!(mode & 0111)) /* with at least _one_ execute bit set */
		return -EACCES;
		if (bprm->file->f_op == NULL)
		return -EACCES;

Admin message