Commit 913047e9 authored Dec 15, 2011 by Girish K S Committed by Chris Ball Jan 11, 2012

mmc: core: Fix voltage select in DDR mode



This patch fixes the wrong comparison before setting the interface
voltage in DDR mode.

The assignment to the variable ddr before comaprison is either
ddr = MMC_1_2V_DDR_MODE; or ddr == MMC_1_8V_DDR_MODE. But the comparison
is done with the extended csd value if ddr == EXT_CSD_CARD_TYPE_DDR_1_2V.

Signed-off-by: Girish K S <girish.shivananjappa@linaro.org>
Acked-by: Subhash Jadavani <subhashj@codeaurora.org>
Acked-by: Philip Rakity <prakity@marvell.com>
Cc: <stable@kernel.org>
Signed-off-by: Chris Ball <cjb@laptop.org>

parent 7003fecb

drivers/mmc/core/mmc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1058,7 +1058,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
		*
		* WARNING: eMMC rules are NOT the same as SD DDR
		*/
		if (ddr == EXT_CSD_CARD_TYPE_DDR_1_2V) {
		if (ddr == MMC_1_2V_DDR_MODE) {
		err = mmc_set_signal_voltage(host,
		MMC_SIGNAL_VOLTAGE_120, 0);
		if (err)

Admin message