Commit 912ed8af authored Dec 19, 2017 by Colin Ian King Committed by Greg Kroah-Hartman Jan 02, 2018

mei: fix incorrect logical operator in if statement



The current expression using the || operator is always true because
dev->dev_state cannot be equal to two different values at the same time.
Fix this by replacing the || with &&.

Detected by CoverityScan, CID#1463042 ("Constant expression result")

Fixes: 8d52af67 ("mei: speed up the power down flow")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent cc365dcf

drivers/misc/mei/hw-me.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1261,7 +1261,7 @@ irqreturn_t mei_me_irq_thread_handler(int irq, void *dev_id)
		break;

		if (rets &&
		(dev->dev_state != MEI_DEV_RESETTING \|\|
		(dev->dev_state != MEI_DEV_RESETTING &&
		dev->dev_state != MEI_DEV_POWER_DOWN)) {
		dev_err(dev->dev, "mei_irq_read_handler ret = %d.\n",
		rets);

Admin message