Commit 912e837a authored Sep 22, 2009 by Roel Kluin Committed by Linus Torvalds Sep 23, 2009

dme1737: Keep index within pwm_config[]



The static code scanner "Parfait" reported this because pwm_config is
only 3 bytes - pwm_config[3] is out of range.

Since this code path is never called with ix == 3 (the device has no PWM4
output) this doesn't change anything in practice.  But to encourage
testing with Parfait, lets make the warning go away...

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 54fdade1

drivers/hwmon/dme1737.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1134,7 +1134,7 @@ static ssize_t show_pwm(struct device dev, struct device_attribute attr,
		res = PWM_FREQ_FROM_REG(data->pwm_freq[ix]);
		break;
		case SYS_PWM_ENABLE:
		if (ix > 3) {
		if (ix >= 3) {
		res = 1; /* pwm[5-6] hard-wired to manual mode */
		} else {
		res = PWM_EN_FROM_REG(data->pwm_config[ix]);

Admin message