Commit 912dee57 authored by Andrew Jones's avatar Andrew Jones Committed by Marc Zyngier
Browse files

KVM: arm64: Check RAZ visibility in ID register accessors 



The instruction encodings of ID registers are preallocated. Until an
encoding is assigned a purpose the register is RAZ. KVM's general ID
register accessor functions already support both paths, RAZ or not.
If for each ID register we can determine if it's RAZ or not, then all
ID registers can build on the general functions. The register visibility
function allows us to check whether a register should be completely
hidden or not, extending it to also report when the register should
be RAZ or not allows us to use it for ID registers as well.

Check for RAZ visibility in the ID register accessor functions,
allowing the RAZ case to be handled in a generic way for all system
registers.

The new REG_RAZ flag will be used in a later patch. This patch has
no intended functional change.

Signed-off-by: default avatarAndrew Jones <drjones@redhat.com>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20201105091022.15373-4-drjones@redhat.com
parent 01fe5ace

arch/arm64/kvm/sys_regs.c

+16 −3
Original line number Diff line number Diff line
@@ -1151,6 +1151,12 @@ static u64 read_id_reg(const struct kvm_vcpu *vcpu, 
	return val;

}



static unsigned int id_visibility(const struct kvm_vcpu *vcpu,

				  const struct sys_reg_desc *r)

{

	return 0;

}



/* cpufeature ID register access trap handlers */



static bool __access_id_reg(struct kvm_vcpu *vcpu,
@@ -1169,7 +1175,9 @@ static bool access_id_reg(struct kvm_vcpu *vcpu, 
			  struct sys_reg_params *p,

			  const struct sys_reg_desc *r)

{

	return __access_id_reg(vcpu, p, r, false);

	bool raz = sysreg_visible_as_raz(vcpu, r);



	return __access_id_reg(vcpu, p, r, raz);

}



static bool access_raz_id_reg(struct kvm_vcpu *vcpu,
@@ -1281,13 +1289,17 @@ static int __set_id_reg(const struct kvm_vcpu *vcpu, 
static int get_id_reg(struct kvm_vcpu *vcpu, const struct sys_reg_desc *rd,

		      const struct kvm_one_reg *reg, void __user *uaddr)

{

	return __get_id_reg(vcpu, rd, uaddr, false);

	bool raz = sysreg_visible_as_raz(vcpu, rd);



	return __get_id_reg(vcpu, rd, uaddr, raz);

}



static int set_id_reg(struct kvm_vcpu *vcpu, const struct sys_reg_desc *rd,

		      const struct kvm_one_reg *reg, void __user *uaddr)

{

	return __set_id_reg(vcpu, rd, uaddr, false);

	bool raz = sysreg_visible_as_raz(vcpu, rd);



	return __set_id_reg(vcpu, rd, uaddr, raz);

}



static int get_raz_id_reg(struct kvm_vcpu *vcpu, const struct sys_reg_desc *rd,
@@ -1372,6 +1384,7 @@ static bool access_ccsidr(struct kvm_vcpu *vcpu, struct sys_reg_params *p, 
	.access	= access_id_reg,		\

	.get_user = get_id_reg,			\

	.set_user = set_id_reg,			\

	.visibility = id_visibility,		\

}



/*

arch/arm64/kvm/sys_regs.h

+10 −0
Original line number Diff line number Diff line
@@ -60,6 +60,7 @@ struct sys_reg_desc { 
};



#define REG_HIDDEN		(1 << 0) /* hidden from userspace and guest */

#define REG_RAZ			(1 << 1) /* RAZ from userspace and guest */



static __printf(2, 3)

inline void print_sys_reg_msg(const struct sys_reg_params *p,
@@ -119,6 +120,15 @@ static inline bool sysreg_hidden(const struct kvm_vcpu *vcpu, 
	return r->visibility(vcpu, r) & REG_HIDDEN;

}



static inline bool sysreg_visible_as_raz(const struct kvm_vcpu *vcpu,

					 const struct sys_reg_desc *r)

{

	if (likely(!r->visibility))

		return false;



	return r->visibility(vcpu, r) & REG_RAZ;

}



static inline int cmp_sys_reg(const struct sys_reg_desc *i1,

			      const struct sys_reg_desc *i2)

{

CRA Git | Maintained and supported by SUSTech CRA and CCSE