Commit 91227632 authored Jul 23, 2019 by Nishka Dasgupta Committed by Boris Brezillon Aug 11, 2019

i3c: master: Add of_node_put() before return



Each iteration of for_each_available_childe_of_node puts the previous
node, but in the case of a return from the middle of the loop, there
is no put, thus causing a memory leak. Add an of_node_put before the
return.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>

parent 934d24a5

drivers/i3c/master.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -2048,9 +2048,11 @@ static int of_populate_i3c_bus(struct i3c_master_controller *master)

		for_each_available_child_of_node(i3cbus_np, node) {
		ret = of_i3c_master_add_dev(master, node);
		if (ret)
		if (ret) {
		of_node_put(node);
		return ret;
		}
		}

		/*
		* The user might want to limit I2C and I3C speed in case some devices

Admin message