Commit 911656f8 authored Jul 28, 2005 by Stephen Smalley Committed by Linus Torvalds Jul 28, 2005

[PATCH] selinux: Fix address length checks in connect hook



This patch fixes the address length checks in the selinux_socket_connect
hook to be no more restrictive than the underlying ipv4 and ipv6 code;
otherwise, this hook can reject valid connect calls.  This patch is in
response to a bug report where an application was calling connect on an
INET6 socket with an address that didn't include the optional scope id and
failing due to these checks.

Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
Signed-off-by: James Morris <jmorris@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent f0b9d796

security/selinux/hooks.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -3126,12 +3126,12 @@ static int selinux_socket_connect(struct socket sock, struct sockaddr address,

		if (sk->sk_family == PF_INET) {
		addr4 = (struct sockaddr_in *)address;
		if (addrlen != sizeof(struct sockaddr_in))
		if (addrlen < sizeof(struct sockaddr_in))
		return -EINVAL;
		snum = ntohs(addr4->sin_port);
		} else {
		addr6 = (struct sockaddr_in6 *)address;
		if (addrlen != sizeof(struct sockaddr_in6))
		if (addrlen < SIN6_LEN_RFC2133)
		return -EINVAL;
		snum = ntohs(addr6->sin6_port);
		}

Admin message