Commit 91109f42 authored May 26, 2017 by Johannes Berg Committed by Luca Coelho Jun 29, 2017

iwlwifi: mvm: use proper CDB check in PHY context modify

When the firmware supports CDB, PHY contexts cannot be modified to
change their band, but need to be added/remove instead. Instead of
relying on iwl_mvm_has_new_tx_api(), check the right FW capa flag
IWL_UCODE_TLV_CAPA_BINDING_CDB_SUPPORT and remove the comment.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

parent 4e37b063

drivers/net/wireless/intel/iwlwifi/mvm/phy-ctxt.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -255,8 +255,8 @@ int iwl_mvm_phy_ctxt_changed(struct iwl_mvm mvm, struct iwl_mvm_phy_ctxt ctxt,

		lockdep_assert_held(&mvm->mutex);

		/* In CDB mode we cannot modify PHY context between bands so... */
		if (iwl_mvm_has_new_tx_api(mvm) &&
		if (fw_has_capa(&mvm->fw->ucode_capa,
		IWL_UCODE_TLV_CAPA_BINDING_CDB_SUPPORT) &&
		ctxt->channel->band != chandef->chan->band) {
		int ret;

Admin message