Commit 9104ae49 authored Nov 04, 2019 by Arnd Bergmann Committed by J. Bruce Fields Dec 19, 2019

nfsd: use ktime_get_real_seconds() in nfs4_verifier



gen_confirm() generates a unique identifier based on the current
time. This overflows in year 2038, but that is harmless since it
generally does not lead to duplicates, as long as the time has
been initialized by a real-time clock or NTP.

Using ktime_get_boottime_seconds() or ktime_get_seconds() would
avoid the overflow, but it would be more likely to result in
non-unique numbers.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

parent 20b7d86f

fs/nfsd/nfs4state.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2264,7 +2264,7 @@ static void gen_confirm(struct nfs4_client clp, struct nfsd_net nn)
		* This is opaque to client, so no need to byte-swap. Use
		* __force to keep sparse happy
		*/
		verf[0] = (__force __be32)get_seconds();
		verf[0] = (__force __be32)(u32)ktime_get_real_seconds();
		verf[1] = (__force __be32)nn->clverifier_counter++;
		memcpy(clp->cl_confirm.data, verf, sizeof(clp->cl_confirm.data));
		}

Admin message