Commit 90f9dd8f authored Feb 16, 2006 by NeilBrown Committed by Linus Torvalds Feb 16, 2006

[PATCH] Fix over-zealous tag clearing in radix_tree_delete



If a tag is set for a node being deleted from a radix_tree, then that
tag gets cleared from the parent of the node, even if it is set for some
siblings of the node begin deleted.

This patch changes the logic to include a test for any_tag_set similar
to the logic a little futher down.  Care is taken to ensure that
'nr_cleared_tags' remains equals to the number of entries in the 'tags'
array which are set to '0' (which means that this tag is not set in the
tree below pathp->node, and should be cleared at pathp->node and
possibly above.

[ Nick says: "Linus FYI, I was able to modify the radix tree test
  harness to catch the bug and can no longer trigger it after the fix.
  Resulting code passes all other harness tests as well of course." ]

Signed-off-by: Neil Brown <neilb@suse.de>
Acked-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent d89b8f40

lib/radix-tree.c

+6 −4

Original line number	Diff line number	Diff line
		@@ -752,12 +752,14 @@ void radix_tree_delete(struct radix_tree_root root, unsigned long index)
		*/
		nr_cleared_tags = 0;
		for (tag = 0; tag < RADIX_TREE_TAGS; tag++) {
		tags[tag] = 1;
		if (tag_get(pathp->node, tag, pathp->offset)) {
		tag_clear(pathp->node, tag, pathp->offset);
		if (!any_tag_set(pathp->node, tag)) {
		tags[tag] = 0;
		nr_cleared_tags++;
		} else
		tags[tag] = 1;
		}
		}
		}

		for (pathp--; nr_cleared_tags && pathp->node; pathp--) {

Admin message