Commit 90cf500e authored Aug 09, 2019 by Trond Myklebust

NFSv4: Fix return values for nfs4_file_open()



Currently, we are translating RPC level errors such as timeouts,
as well as interrupts etc into EOPENSTALE, which forces a single
replay of the open attempt. What we actually want to do is
force the replay only in the cases where the returned error
indicates that the file may have changed on the server.

So the fix is to spell out the exact set of errors where we want
to return EOPENSTALE.

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>

parent 7e10cc25

fs/nfs/nfs4file.c

+6 −6

Original line number	Diff line number	Diff line
		@@ -73,13 +73,13 @@ nfs4_file_open(struct inode inode, struct file filp)
		if (IS_ERR(inode)) {
		err = PTR_ERR(inode);
		switch (err) {
		case -EPERM:
		case -EACCES:
		case -EDQUOT:
		case -ENOSPC:
		case -EROFS:
		goto out_put_ctx;
		default:
		goto out_put_ctx;
		case -ENOENT:
		case -ESTALE:
		case -EISDIR:
		case -ENOTDIR:
		case -ELOOP:
		goto out_drop;
		}
		}

Admin message