Commit 90bad5e0 authored Aug 06, 2018 by Al Viro

root dentries need RCU-delayed freeing



Since mountpoint crossing can happen without leaving lazy mode,
root dentries do need the same protection against having their
memory freed without RCU delay as everything else in the tree.

It's partially hidden by RCU delay between detaching from the
mount tree and dropping the vfsmount reference, but the starting
point of pathwalk can be on an already detached mount, in which
case umount-caused RCU delay has already passed by the time the
lazy pathwalk grabs rcu_read_lock().  If the starting point
happens to be at the root of that vfsmount *and* that vfsmount
covers the entire filesystem, we get trouble.

Fixes: 48a066e7 ("RCU'd vsfmounts")
Cc: stable@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent 9ba546c0

fs/dcache.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -1932,11 +1932,13 @@ struct dentry d_make_root(struct inode root_inode)

		if (root_inode) {
		res = d_alloc_anon(root_inode->i_sb);
		if (res)
		if (res) {
		res->d_flags \|= DCACHE_RCUACCESS;
		d_instantiate(res, root_inode);
		else
		} else {
		iput(root_inode);
		}
		}
		return res;
		}
		EXPORT_SYMBOL(d_make_root);

Admin message