Commit 90b4f30b authored May 10, 2017 by Thomas Gleixner Committed by Guenter Roeck May 14, 2017

hwmon: (coretemp) Handle frozen hotplug state correctly



The recent conversion to the hotplug state machine missed that the original
hotplug notifiers did not execute in the frozen state, which is used on
suspend on resume.

This does not matter on single socket machines, but on multi socket systems
this breaks when the device for a non-boot socket is removed when the last
CPU of that socket is brought offline. The device removal locks up the
machine hard w/o any debug output.

Prevent executing the hotplug callbacks when cpuhp_tasks_frozen is true.

Thanks to Tommi for providing debug information patiently while I failed to
spot the obvious.

Fixes: e00ca5df ("hwmon: (coretemp) Convert to hotplug state machine")
Reported-by: Tommi Rantala <tt.rantala@gmail.com>
Tested-by: Tommi Rantala <tt.rantala@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent 2ea659a9

drivers/hwmon/coretemp.c

+14 −0

Original line number	Diff line number	Diff line
		@@ -604,6 +604,13 @@ static int coretemp_cpu_online(unsigned int cpu)
		struct cpuinfo_x86 *c = &cpu_data(cpu);
		struct platform_data *pdata;

		/*
		* Don't execute this on resume as the offline callback did
		* not get executed on suspend.
		*/
		if (cpuhp_tasks_frozen)
		return 0;

		/*
		* CPUID.06H.EAX[0] indicates whether the CPU has thermal
		* sensors. We check this bit only, all the early CPUs
		@@ -654,6 +661,13 @@ static int coretemp_cpu_offline(unsigned int cpu)
		struct temp_data *tdata;
		int indx, target;

		/*
		* Don't execute this on suspend as the device remove locks
		* up the machine.
		*/
		if (cpuhp_tasks_frozen)
		return 0;

		/* If the physical CPU device does not exist, just return */
		if (!pdev)
		return 0;

Admin message