Commit 90a8e82d authored Dec 05, 2019 by Jacek Anaszewski Committed by Pavel Machek Jan 22, 2020

leds: gpio: Fix uninitialized gpio label for fwnode based probe



When switching to using generic LED name composition mechanism via
devm_led_classdev_register_ext() API the part of code initializing
struct gpio_led's template name property was removed alongside.
It was however overlooked that the property was also passed to
devm_fwnode_get_gpiod_from_child() in place of "label" parameter,
which when set to NULL, results in gpio label being initialized to '?'.

It could be observed in debugfs and failed to properly identify
gpio association with LED consumer.

Fix this shortcoming by updating the GPIO label after the LED is
registered and its final name is known.

Fixes: d7235f5f ("leds: gpio: Use generic support for composing LED names")
Cc: Russell King <linux@armlinux.org.uk>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
[fixed comment]
Signed-off-by: Pavel Machek <pavel@ucw.cz>

parent d1eef1c6

drivers/leds/leds-gpio.c

+9 −1

Original line number	Diff line number	Diff line
		@@ -151,9 +151,14 @@ static struct gpio_leds_priv gpio_leds_create(struct platform_device pdev)
		struct gpio_led led = {};
		const char *state = NULL;

		/*
		* Acquire gpiod from DT with uninitialized label, which
		* will be updated after LED class device is registered,
		* Only then the final LED name is known.
		*/
		led.gpiod = devm_fwnode_get_gpiod_from_child(dev, NULL, child,
		GPIOD_ASIS,
		led.name);
		NULL);
		if (IS_ERR(led.gpiod)) {
		fwnode_handle_put(child);
		return ERR_CAST(led.gpiod);
		@@ -186,6 +191,9 @@ static struct gpio_leds_priv gpio_leds_create(struct platform_device pdev)
		fwnode_handle_put(child);
		return ERR_PTR(ret);
		}
		/* Set gpiod label to match the corresponding LED name. */
		gpiod_set_consumer_name(led_dat->gpiod,
		led_dat->cdev.dev->kobj.name);
		priv->num_leds++;
		}

Admin message