Commit 909e22e0 authored Nov 19, 2018 by YueHaibing Committed by Al Viro Nov 18, 2018

exportfs: fix 'passing zero to ERR_PTR()' warning



Fix a static code checker warning:
  fs/exportfs/expfs.c:171 reconnect_one() warn: passing zero to 'ERR_PTR'

The error path for lookup_one_len_unlocked failure
should set err to PTR_ERR.

Fixes: bbf7a8a3 ("exportfs: move most of reconnect_path to helper function")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent 53fffe29

fs/exportfs/expfs.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -147,6 +147,7 @@ static struct dentry reconnect_one(struct vfsmount mnt,
		tmp = lookup_one_len_unlocked(nbuf, parent, strlen(nbuf));
		if (IS_ERR(tmp)) {
		dprintk("%s: lookup failed: %d\n", __func__, PTR_ERR(tmp));
		err = PTR_ERR(tmp);
		goto out_err;
		}
		if (tmp != dentry) {

Admin message