Commit 909c2f32 authored by Jarkko Nikula's avatar Jarkko Nikula Committed by Liam Girdwood
Browse files

ASoC: tlv320aic3x: Add correct hw registers to Line1 cross connect muxes 



Commit af46800b ("ASoC: Implement mux control sharing") revealed that
"Left Line1[L | R] Mux" and "Right Line1[L | R] Mux" widgets were pointing
to the same kcontrols and codec registers and thus soc-core falsely detected
them as shared controls. This is actually wrong since there are separate
registers in hardware that configure Line1L to RADC and Line1R to LADC cross
connects so these muxes should not be shared.

Signed-off-by: default avatarJarkko Nikula <jhnikula@gmail.com>
Acked-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: default avatarLiam Girdwood <lrg@slimlogic.co.uk>
parent 5de70519

sound/soc/codecs/tlv320aic3x.c

+21 −13
Original line number Diff line number Diff line
@@ -226,11 +226,13 @@ static const char *aic3x_adc_hpf[] = 
#define RDAC_ENUM	1

#define LHPCOM_ENUM	2

#define RHPCOM_ENUM	3

#define LINE1L_ENUM	4

#define LINE1R_ENUM	5

#define LINE2L_ENUM	6

#define LINE2R_ENUM	7

#define ADC_HPF_ENUM	8

#define LINE1L_2_L_ENUM	4

#define LINE1L_2_R_ENUM	5

#define LINE1R_2_L_ENUM	6

#define LINE1R_2_R_ENUM	7

#define LINE2L_ENUM	8

#define LINE2R_ENUM	9

#define ADC_HPF_ENUM	10



static const struct soc_enum aic3x_enum[] = {

	SOC_ENUM_SINGLE(DAC_LINE_MUX, 6, 3, aic3x_left_dac_mux),
@@ -238,6 +240,8 @@ static const struct soc_enum aic3x_enum[] = { 
	SOC_ENUM_SINGLE(HPLCOM_CFG, 4, 3, aic3x_left_hpcom_mux),

	SOC_ENUM_SINGLE(HPRCOM_CFG, 3, 5, aic3x_right_hpcom_mux),

	SOC_ENUM_SINGLE(LINE1L_2_LADC_CTRL, 7, 2, aic3x_linein_mode_mux),

	SOC_ENUM_SINGLE(LINE1L_2_RADC_CTRL, 7, 2, aic3x_linein_mode_mux),

	SOC_ENUM_SINGLE(LINE1R_2_LADC_CTRL, 7, 2, aic3x_linein_mode_mux),

	SOC_ENUM_SINGLE(LINE1R_2_RADC_CTRL, 7, 2, aic3x_linein_mode_mux),

	SOC_ENUM_SINGLE(LINE2L_2_LADC_CTRL, 7, 2, aic3x_linein_mode_mux),

	SOC_ENUM_SINGLE(LINE2R_2_RADC_CTRL, 7, 2, aic3x_linein_mode_mux),
@@ -490,12 +494,16 @@ static const struct snd_kcontrol_new aic3x_right_pga_mixer_controls[] = { 
};



/* Left Line1 Mux */

static const struct snd_kcontrol_new aic3x_left_line1_mux_controls =

SOC_DAPM_ENUM("Route", aic3x_enum[LINE1L_ENUM]);

static const struct snd_kcontrol_new aic3x_left_line1l_mux_controls =

SOC_DAPM_ENUM("Route", aic3x_enum[LINE1L_2_L_ENUM]);

static const struct snd_kcontrol_new aic3x_right_line1l_mux_controls =

SOC_DAPM_ENUM("Route", aic3x_enum[LINE1L_2_R_ENUM]);



/* Right Line1 Mux */

static const struct snd_kcontrol_new aic3x_right_line1_mux_controls =

SOC_DAPM_ENUM("Route", aic3x_enum[LINE1R_ENUM]);

static const struct snd_kcontrol_new aic3x_right_line1r_mux_controls =

SOC_DAPM_ENUM("Route", aic3x_enum[LINE1R_2_R_ENUM]);

static const struct snd_kcontrol_new aic3x_left_line1r_mux_controls =

SOC_DAPM_ENUM("Route", aic3x_enum[LINE1R_2_L_ENUM]);



/* Left Line2 Mux */

static const struct snd_kcontrol_new aic3x_left_line2_mux_controls =
@@ -535,9 +543,9 @@ static const struct snd_soc_dapm_widget aic3x_dapm_widgets[] = { 
			   &aic3x_left_pga_mixer_controls[0],

			   ARRAY_SIZE(aic3x_left_pga_mixer_controls)),

	SND_SOC_DAPM_MUX("Left Line1L Mux", SND_SOC_NOPM, 0, 0,

			 &aic3x_left_line1_mux_controls),

			 &aic3x_left_line1l_mux_controls),

	SND_SOC_DAPM_MUX("Left Line1R Mux", SND_SOC_NOPM, 0, 0,

			 &aic3x_left_line1_mux_controls),

			 &aic3x_left_line1r_mux_controls),

	SND_SOC_DAPM_MUX("Left Line2L Mux", SND_SOC_NOPM, 0, 0,

			 &aic3x_left_line2_mux_controls),
@@ -548,9 +556,9 @@ static const struct snd_soc_dapm_widget aic3x_dapm_widgets[] = { 
			   &aic3x_right_pga_mixer_controls[0],

			   ARRAY_SIZE(aic3x_right_pga_mixer_controls)),

	SND_SOC_DAPM_MUX("Right Line1L Mux", SND_SOC_NOPM, 0, 0,

			 &aic3x_right_line1_mux_controls),

			 &aic3x_right_line1l_mux_controls),

	SND_SOC_DAPM_MUX("Right Line1R Mux", SND_SOC_NOPM, 0, 0,

			 &aic3x_right_line1_mux_controls),

			 &aic3x_right_line1r_mux_controls),

	SND_SOC_DAPM_MUX("Right Line2R Mux", SND_SOC_NOPM, 0, 0,

			 &aic3x_right_line2_mux_controls),

CRA Git | Maintained and supported by SUSTech CRA and CCSE