Commit 907be2a6 authored Jul 14, 2020 by Dan Carpenter Committed by Ulf Hansson Jul 24, 2020

mmc: sdhci: Fix a potential uninitialized variable



Smatch complains that "ret" can be used without being initialized.

drivers/mmc/host/sdhci.c
  4383          if (!IS_ERR(mmc->supply.vqmmc)) {
  4384                  if (enable_vqmmc) {
                            ^^^^^^^^^^^^
  4385                          ret = regulator_enable(mmc->supply.vqmmc);
                                ^^^^^
  4386                          host->sdhci_core_to_disable_vqmmc = !ret;
  4387                  }

"ret" is only initialized when "enable_vqmmc" is true.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20200714141410.GB314989@mwanda


Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent a1c76734

drivers/mmc/host/sdhci.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4104,7 +4104,7 @@ int sdhci_setup_host(struct sdhci_host *host)
		unsigned int ocr_avail;
		unsigned int override_timeout_clk;
		u32 max_clk;
		int ret;
		int ret = 0;
		bool enable_vqmmc = false;

		WARN_ON(host == NULL);

Admin message