Commit 90670fdf authored Jul 03, 2020 by Kai Vehmanen Committed by Takashi Iwai Jul 07, 2020

ALSA: hda/hdmi: improve debug traces for stream lookups



The HDMI codec driver has two debug traces printed from different
functions but with identical message content:

"HDMI: hinfo 000000006a6b84d9 not registered"

Fix this duplication and also add a bit more context in addition to raw
object pointer, to help analysis of kernel logs.

Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20200703153818.2808592-2-kai.vehmanen@linux.intel.com


Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 56275036

sound/pci/hda/patch_hdmi.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -259,7 +259,7 @@ static int hinfo_to_pcm_index(struct hda_codec *codec,
		if (get_pcm_rec(spec, pcm_idx)->stream == hinfo)
		return pcm_idx;

		codec_warn(codec, "HDMI: hinfo %p not registered\n", hinfo);
		codec_warn(codec, "HDMI: hinfo %p not tied to a PCM\n", hinfo);
		return -EINVAL;
		}

		@@ -277,7 +277,8 @@ static int hinfo_to_pin_index(struct hda_codec *codec,
		return pin_idx;
		}

		codec_dbg(codec, "HDMI: hinfo %p not registered\n", hinfo);
		codec_dbg(codec, "HDMI: hinfo %p (pcm %d) not registered\n", hinfo,
		hinfo_to_pcm_index(codec, hinfo));
		return -EINVAL;
		}

Admin message