Commit 906470c1 authored Aug 18, 2015 by Phil Sutter Committed by David S. Miller Aug 18, 2015

net: warn if drivers set tx_queue_len = 0

Due to the introduction of IFF_NO_QUEUE, there is a better way for
drivers to indicate that no qdisc should be attached by default. Though,
the old convention can't be dropped since ignoring that setting would
break drivers still using it. Instead, add a warning so out-of-tree
driver maintainers get a chance to adjust their code before we finally
get rid of any special handling of tx_queue_len == 0.

Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7d9e437d

net/core/dev.c

+3 −0

Original line number	Original line	Diff line number	Diff line
	@@ -6997,6 +6997,9 @@ struct net_device alloc_netdev_mqs(int sizeof_priv, const char name,
	dev->priv_flags = IFF_XMIT_DST_RELEASE \| IFF_XMIT_DST_RELEASE_PERM;		dev->priv_flags = IFF_XMIT_DST_RELEASE \| IFF_XMIT_DST_RELEASE_PERM;
	setup(dev);		setup(dev);

			if (!dev->tx_queue_len)
			printk(KERN_WARNING "%s uses DEPRECATED zero tx_queue_len - convert driver to use IFF_NO_QUEUE instead.\n", name);

	dev->num_tx_queues = txqs;		dev->num_tx_queues = txqs;
	dev->real_num_tx_queues = txqs;		dev->real_num_tx_queues = txqs;
	if (netif_alloc_netdev_queues(dev))		if (netif_alloc_netdev_queues(dev))

Admin message