Commit 90085930 authored Jun 01, 2011 by Akinobu Mita Committed by Jan Kara Jun 25, 2011

ext3: use proper little-endian bitops



ext3_{set,clear}_bit() is defined as __test_and_{set,clear}_bit_le()
for ext3.  But all ext3_{set,clear}_bit() calls ignore return values.
So these can be replaced with __{set,clear}_bit_le().

This changes ext3_{set,clear}_bit safely, because if someone uses
these macros without noticing the change, new ext3_{set,clear}_bit
don't have return value and causes compiler errors where the return
value is used.

This also removes unused ext3_find_first_zero_bit().

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Cc: linux-ext4@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>

parent fbcc9e62

include/linux/ext3_fs.h

+2 −3

Original line number	Diff line number	Diff line
		@@ -418,12 +418,11 @@ struct ext3_inode {
		#define EXT2_MOUNT_DATA_FLAGS EXT3_MOUNT_DATA_FLAGS
		#endif

		#define ext3_set_bit __test_and_set_bit_le
		#define ext3_set_bit __set_bit_le
		#define ext3_set_bit_atomic ext2_set_bit_atomic
		#define ext3_clear_bit __test_and_clear_bit_le
		#define ext3_clear_bit __clear_bit_le
		#define ext3_clear_bit_atomic ext2_clear_bit_atomic
		#define ext3_test_bit test_bit_le
		#define ext3_find_first_zero_bit find_first_zero_bit_le
		#define ext3_find_next_zero_bit find_next_zero_bit_le

		/*

Admin message