Commit 8ffd3208 authored Dec 21, 2009 by Andrew Morton Committed by David S. Miller Jan 03, 2010

net/sctp/socket.c: squish warning

net/sctp/socket.c: In function 'sctp_setsockopt_autoclose':
net/sctp/socket.c:2090: warning: comparison is always false due to limited range of data type

Cc: Andrei Pelinescu-Onciul <andrei@iptel.org>
Cc: Vlad Yasevich <vladislav.yasevich@hp.com>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1f731b63

net/sctp/socket.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -2087,8 +2087,7 @@ static int sctp_setsockopt_autoclose(struct sock sk, char __user optval,
		if (copy_from_user(&sp->autoclose, optval, optlen))
		return -EFAULT;
		/* make sure it won't exceed MAX_SCHEDULE_TIMEOUT */
		if (sp->autoclose > (MAX_SCHEDULE_TIMEOUT / HZ) )
		sp->autoclose = (__u32)(MAX_SCHEDULE_TIMEOUT / HZ) ;
		sp->autoclose = min_t(long, sp->autoclose, MAX_SCHEDULE_TIMEOUT / HZ);

		return 0;
		}

Admin message